Page MenuHomeSoftware Heritage
Differential D2937

in_memory storage: Adapt internal implementations to use origin visit status model representation
ClosedPublic
Actions

Authored by ardumont on Apr 1 2020, 12:09 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Maniphest Tasks
T2310: Make origin visits immutable
Commits
rDSTOead80889fb44: in_memory: Adapt internal implementations to use origin visit update
Summary

Introduce internally the origin visit status model change.
Without changing the client facing api.

Related to T2310
Related to D2879

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
make-origin-visit-immutable
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 12090
Build 18344: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18343: arc lint + arc unit

Event Timeline

ardumont created this revision.Apr 1 2020, 12:09 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 1 2020, 12:09 PM
ardumont added a child revision: D2938: pg-storage: Adapt internal implementations to use origin visit status model representation.Apr 1 2020, 12:10 PM
ardumont mentioned this in D2879: storage: Refactor internal implementations to use "origin visit update" model representation.Apr 1 2020, 12:12 PM
swh-public-ci added a comment.Apr 1 2020, 12:16 PM

Build is green

Patch application report for D2937 (id=10448)

Rebasing onto 377e6a8072...

Current branch diff-target is up to date.
Changes applied before test
commit b29327fd7cb7316ae6ba3ad27f53971d696d324f
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/43/ for more details.

Harbormaster completed remote builds in B11533: Diff 10448.Apr 1 2020, 12:16 PM
ardumont updated this revision to Diff 10454.Apr 1 2020, 2:42 PM

Amend commit with specific in-memory code (committed in the wrong one)

Harbormaster completed remote builds in B11539: Diff 10454.Apr 1 2020, 2:48 PM
swh-public-ci added a comment.Apr 1 2020, 2:48 PM

Build is green

Patch application report for D2937 (id=10454)

Rebasing onto 377e6a8072...

Current branch diff-target is up to date.
Changes applied before test
commit c0b05980ca3a19afa30fba6e75d067aaeac2cc96
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/46/ for more details.

ardumont updated this revision to Diff 10459.Apr 1 2020, 3:17 PM

Rebase on latest master

douardda accepted this revision.Apr 1 2020, 3:21 PM
douardda added a subscriber: douardda.

LGTM

This revision is now accepted and ready to land.Apr 1 2020, 3:21 PM
swh-public-ci added a comment.Apr 1 2020, 3:22 PM

Build is green

Patch application report for D2937 (id=10459)

Rebasing onto df3207a6b7...

Current branch diff-target is up to date.
Changes applied before test
commit c7ca0d04ff2d74150a1acde201b278d03d5a94d1
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/48/ for more details.

Harbormaster completed remote builds in B11552: Diff 10459.Apr 1 2020, 3:22 PM
ardumont mentioned this in T2310: Make origin visits immutable.Apr 1 2020, 4:40 PM
ardumont updated this revision to Diff 10641.EditedApr 9 2020, 4:15 PM

Rebase on latest master and blackify

swh-public-ci added a comment.Apr 9 2020, 4:20 PM

Build is green

Patch application report for D2937 (id=10641)

Rebasing onto b0b0313c96...

Current branch diff-target is up to date.
Changes applied before test
commit 65a4044601d1c8259585a127c28a7b5c23a3d1c6
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/81/ for more details.

Harbormaster completed remote builds in B11761: Diff 10641.Apr 9 2020, 4:20 PM
ardumont mentioned this in D3001: model: Rename OriginVisitUpdate to OriginVisitStatus.Apr 10 2020, 11:20 AM
ardumont updated this revision to Diff 10692.Apr 10 2020, 5:48 PM
  • rebase to latest master
  • update to use the latest OriginVisitStatus model object
swh-public-ci added a comment.Apr 10 2020, 5:54 PM

Build is green

Patch application report for D2937 (id=10692)

Rebasing onto ddac3d27e3...

Current branch diff-target is up to date.
Changes applied before test
commit 88fa1b0e22dd1996afeee99ffcbccd0c8c3be110
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/90/ for more details.

Harbormaster completed remote builds in B11813: Diff 10692.Apr 10 2020, 5:54 PM
ardumont retitled this revision from in_memory storage: Adapt internal implementations to use origin visit update model representation to in_memory storage: Adapt internal implementations to use origin visit status model representation.Apr 10 2020, 5:57 PM
ardumont added a task: T2310: Make origin visits immutable.Apr 14 2020, 10:47 AM
ardumont updated this revision to Diff 10819.Apr 22 2020, 2:37 PM

Rebase on latest master

ardumont edited the summary of this revision. (Show Details)Apr 22 2020, 2:39 PM
ardumont edited the summary of this revision. (Show Details)Apr 22 2020, 2:42 PM
swh-public-ci added a comment.Apr 22 2020, 2:43 PM

Build is green

Patch application report for D2937 (id=10819)

Rebasing onto bca643acab...

Current branch diff-target is up to date.
Changes applied before test
commit 13fc814a0c0bef9487321138cf472b0fdbe48a28
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/108/ for more details.

Harbormaster completed remote builds in B11973: Diff 10819.Apr 22 2020, 2:43 PM
ardumont updated this revision to Diff 10932.Apr 28 2020, 2:38 PM

Rebase on latest master

swh-public-ci added a comment.Apr 28 2020, 2:44 PM

Build is green

Patch application report for D2937 (id=10932)

Rebasing onto 49109d173f...

Current branch diff-target is up to date.
Changes applied before test
commit 9cc80f8f92f37ecdd948179b6bf954b3109382d5
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/137/ for more details.

Harbormaster completed remote builds in B12086: Diff 10932.Apr 28 2020, 2:44 PM
ardumont updated this revision to Diff 10936.Apr 28 2020, 3:00 PM
  • rename visit "update" into visit "status" where it makes sense
  • fix one method to add assertion instead of being an optional result
swh-public-ci added a comment.Apr 28 2020, 3:10 PM

Build is green

Patch application report for D2937 (id=10936)

Rebasing onto 49109d173f...

Current branch diff-target is up to date.
Changes applied before test
commit d3e97b9d9cfa636b7e4a079ee3dcf0851ee34dba
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/141/ for more details.

Harbormaster completed remote builds in B12090: Diff 10936.Apr 28 2020, 3:10 PM
ardumont updated this revision to Diff 10946.Apr 28 2020, 4:47 PM

Change commit email

swh-public-ci added a comment.Apr 28 2020, 4:53 PM

Build is green

Patch application report for D2937 (id=10946)

Rebasing onto 49109d173f...

Current branch diff-target is up to date.
Changes applied before test
commit ead80889fb44d7c0e929b913f3e852ab851c0a3d
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 17:53:48 2020 +0100

    in_memory: Adapt internal implementations to use origin visit update
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B12102: Diff 10946.Apr 28 2020, 4:53 PM
Closed by commit rDSTOead80889fb44: in_memory: Adapt internal implementations to use origin visit update (authored by ardumont). · Explain WhyApr 28 2020, 5:10 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSTOead80889fb44: in_memory: Adapt internal implementations to use origin visit update.
ardumont mentioned this in D3101: pg-storage: Adapt implem to write both origin visit updates and status.Apr 30 2020, 12:03 PM
ardumont mentioned this in rDSTOb0b767b91ca0: pg: Write both origin visit updates & status, read from origin_visit.Apr 30 2020, 2:42 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
2 lines--
swh/
storage/
179 lines96%
Loading...

Diff 10936

View Options

requirements-swh.txt

Loading...
View Options

swh/storage/in_memory.py

Loading...
About · Developer information · Legal