Page MenuHomeSoftware Heritage

browse/release: Add link to directory for revision target type
ClosedPublic

Authored by anlambert on Mar 31 2020, 6:45 PM.

Details

Summary

When browsing a release targetting a revision, also add a link to associated
directory view.

This is somehow related to T2342 and T2330.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 31 2020, 6:45 PM

Build is green

Patch application report for D2935 (id=10434)

Rebasing onto f9172f8a39...

Current branch diff-target is up to date.
Changes applied before test
commit 703144187820e87463e442a95b30e63ee4b94fd6
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 18:44:13 2020 +0200

    browse/release: Add link to directory for revision target type
    
    When browsing a release targetting a revision, also add a link to associated
    directory view.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/35/ for more details.

ardumont accepted this revision.Apr 1 2020, 6:37 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/web/browse/views/release.py
119–120

I guess it's left here on purpose in case the directory is not found.
Maybe add a comment, # ensure the directory exists or something ;)

This revision is now accepted and ready to land.Apr 1 2020, 6:37 PM
anlambert added inline comments.Apr 1 2020, 8:53 PM
swh/web/browse/views/release.py
119–120

You got it right ;-) I will add a comment to clarify.

anlambert updated this revision to Diff 10466.Apr 1 2020, 8:57 PM

Update: Add comment explaining why return value of service.lookup_directory is not used in release view implementation

Build is green

Patch application report for D2935 (id=10466)

Rebasing onto f9172f8a39...

Current branch diff-target is up to date.
Changes applied before test
commit 577ce651e9df86aac9249476396e096715d8d385
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 18:44:13 2020 +0200

    browse/release: Add link to directory for revision target type
    
    When browsing a release targetting a revision, also add a link to associated
    directory view.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/37/ for more details.