Differential D2909

writer: fix skipped_content_add type declaration to use SkippedContent
ClosedPublic
Actions

Authored by douardda on Mar 27 2020, 4:09 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOc67fe217f006: writer: fix skipped_content_add type declaration to use SkippedContent

Summary

instead of plain Content.

Depends on D2908.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 27 2020, 4:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 27 2020, 4:09 PM

douardda added a child revision: D2910: validate: ensure StorageArgumentException is always encodable.Mar 27 2020, 4:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1109/ for more details.

Harbormaster completed remote builds in B11422: Diff 10343.Mar 27 2020, 4:23 PM

Why didn't mypy catch this?

This revision is now accepted and ready to land.Mar 27 2020, 4:46 PM

Closed by commit rDSTOc67fe217f006: writer: fix skipped_content_add type declaration to use SkippedContent (authored by douardda). · Explain WhyMar 30 2020, 3:20 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTOc67fe217f006: writer: fix skipped_content_add type declaration to use SkippedContent.

Revision Contents
Changeset List

Path

Size

swh/

storage/

5 lines

Diff 10382

swh/storage/writer.py

Loading...