Differential D2893

storage*: Update origin_visit_update to make status parameter mandatory
ClosedPublic
Actions

Authored by ardumont on Mar 26 2020, 5:15 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTOce5d2bf433c8: storage*: Update origin_visit_update to make status parameter mandatory

Summary

This actually aligns with the origin_visit model whose status is already
mandatory.

All clients have been adapted already to make sure they
pass the status (D2887 D2888 D2889 D2891).

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

make-status-mandatory

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11376
Build 17222: tox-on-jenkins	Jenkins
Build 17221: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 26 2020, 5:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 26 2020, 5:15 PM

ardumont edited the summary of this revision. (Show Details)Mar 26 2020, 5:16 PM

ardumont edited the test plan for this revision. (Show Details)

vlorentz accepted this revision.Mar 26 2020, 5:16 PM

This revision is now accepted and ready to land.Mar 26 2020, 5:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1097/ for more details.

Harbormaster completed remote builds in B11376: Diff 10295.Mar 26 2020, 5:23 PM

Closed by commit rDSTOce5d2bf433c8: storage*: Update origin_visit_update to make status parameter mandatory (authored by ardumont). · Explain WhyMar 26 2020, 5:24 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOce5d2bf433c8: storage*: Update origin_visit_update to make status parameter mandatory.

Revision Contents
Changeset List

Path

Size

swh/

storage/

cassandra/

8 lines

8 lines

2 lines

8 lines

tests/

test_storage.py

51 lines

Diff 10295

View Options

swh/storage/cassandra/storage.py

View Options

swh/storage/in_memory.py

View Options

swh/storage/interface.py

View Options

swh/storage/storage.py

View Options

swh/storage/tests/test_storage.py

storage*: Update origin_visit_update to make status parameter mandatoryClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10295

swh/storage/cassandra/storage.py

swh/storage/in_memory.py

swh/storage/interface.py

swh/storage/storage.py

swh/storage/tests/test_storage.py

storage*: Update origin_visit_update to make status parameter mandatory
ClosedPublic
Actions

Revision Contents
Changeset List