Differential D2880

model: Add OriginVisitUpdate model object
ClosedPublic
Actions

Authored by ardumont on Mar 25 2020, 6:00 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDMODe9a4c7519e4e: model: Add new OriginVisitUpdate model object + test strategy

Summary

(pairing with @vlorentz)

Need to be updated according to @douardda's latest improvments on model (if that got merged before ;)

Related to T2310

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11335
Build 17151: tox-on-jenkins	Jenkins
Build 17150: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 25 2020, 6:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 25 2020, 6:00 PM

ardumont planned changes to this revision.Mar 25 2020, 6:00 PM

ardumont mentioned this in D2879: storage: Refactor internal implementations to use "origin visit update" model representation.

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/224/ for more details.

Harbormaster completed remote builds in B11335: Diff 10257.Mar 25 2020, 6:01 PM

ardumont edited the summary of this revision. (Show Details)Mar 31 2020, 10:12 AM

ardumont added a subscriber: douardda.

Add tests

ardumont edited the summary of this revision. (Show Details)Mar 31 2020, 5:08 PM

Build is green

Patch application report for D2880 (id=10431)

Rebasing onto accca603c4...

Current branch diff-target is up to date.

Changes applied before test

commit f35783e3e9e01f6c80af75ec8ee97376fa9faabf
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 18:00:03 2020 +0100

    model: Add new OriginVisitUpdate model object + test strategy
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/16/ for more details.

Harbormaster completed remote builds in B11513: Diff 10431.Mar 31 2020, 5:09 PM

ardumont added a child revision: D2879: storage: Refactor internal implementations to use "origin visit update" model representation.Mar 31 2020, 5:57 PM

lgtm, but I'll let @douardda accept the diff

swh/model/hypothesis_strategies.py
92 ↗	(On Diff #10431)	plural, for consistency

Adapt according to review

Build is green

Patch application report for D2880 (id=10433)

Rebasing onto accca603c4...

Current branch diff-target is up to date.

Changes applied before test

commit e9a4c7519e4e2d9763294461f8628a519a3af308
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Mar 25 18:00:03 2020 +0100

    model: Add new OriginVisitUpdate model object + test strategy
    
    (pairing with @vlorentz)
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/17/ for more details.

Harbormaster completed remote builds in B11515: Diff 10433.Mar 31 2020, 6:03 PM

ardumont removed a child revision: D2879: storage: Refactor internal implementations to use "origin visit update" model representation.Mar 31 2020, 6:04 PM

douardda accepted this revision.Apr 1 2020, 9:59 AM

This revision is now accepted and ready to land.Apr 1 2020, 9:59 AM

Closed by commit rDMODe9a4c7519e4e: model: Add new OriginVisitUpdate model object + test strategy (authored by ardumont). · Explain WhyApr 1 2020, 10:06 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMODe9a4c7519e4e: model: Add new OriginVisitUpdate model object + test strategy.

ardumont mentioned this in T2310: Make origin visits immutable.Apr 1 2020, 4:40 PM