Paths

Table of Contentst

Differential D2855

scanner: dump json instead of dict
ClosedPublic
Actions

Authored by DanSeraf on Mar 19 2020, 12:42 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDTSCN5c62848288b0: dump json instead of dict

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Mar 19 2020, 12:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 19 2020, 12:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/17/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/17/console

Harbormaster failed remote builds in B11219: Diff 10153!Mar 19 2020, 12:44 PM

DanSeraf abandoned this revision.Mar 19 2020, 2:12 PM

DanSeraf reclaimed this revision.Mar 19 2020, 4:18 PM

/with jedi mind trick voice

You want to add types
You want to update the tests

;)

In D2855#68683, @ardumont wrote:

/with jedi mind trick voice

You want to add types
You want to update the tests

;)

nice trick :)

tests

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/18/ for more details.

Harbormaster completed remote builds in B11238: Diff 10170.Mar 19 2020, 7:47 PM

vlorentz accepted this revision.Mar 20 2020, 11:39 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/scanner/model.py
58	I suggest using the `indent=4` argument of `json.dumps`, it makes the JSON somewhat human-readable by adding line breaks and indenting. Also `sort_key=True` can be handy

This revision is now accepted and ready to land.Mar 20 2020, 11:39 AM

DanSeraf marked an inline comment as done.Mar 20 2020, 11:54 AM

better json output

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/19/ for more details.

Harbormaster completed remote builds in B11243: Diff 10174.Mar 20 2020, 11:57 AM

rebase

This revision was landed with ongoing or failed builds.Mar 20 2020, 12:17 PM

Closed by commit rDTSCN5c62848288b0: dump json instead of dict (authored by DanSeraf). · Explain Why

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCN5c62848288b0: dump json instead of dict.

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/20/ for more details.

Harbormaster completed remote builds in B11245: Diff 10176.Mar 20 2020, 12:19 PM

Revision Contents
Changeset List

Path

Size

swh/

scanner/

7 lines

tests/

6 lines

test_scanner.py

2 lines

Diff 10177

swh/scanner/model.py

Loading...

swh/scanner/tests/test_model.py

Loading...

swh/scanner/tests/test_scanner.py

Loading...