Don't count origins len(url) times when calling origin_add_one
ClosedPublic
Actions

Authored by olasd on Mar 18 2020, 6:18 PM.

Details

Reviewers

douardda
ardumont

Commits

rDSTOd99f08bf116c: Don't count origins len(url) times when calling origin_add_one

Summary

I guess the origins variable name was carried over from a refactoring, but it
doesn't match what db.origin_add actually returns. Overall this variable name
made us overcount origins a little.

Test Plan

yes, this should probably be tested

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 18 2020, 6:18 PM

ouch, nice catch!

This revision is now accepted and ready to land.Mar 18 2020, 6:20 PM

This revision was landed with ongoing or failed builds.Mar 18 2020, 6:24 PM

Closed by commit rDSTOd99f08bf116c: Don't count origins len(url) times when calling origin_add_one (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTOd99f08bf116c: Don't count origins len(url) times when calling origin_add_one.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1069/ for more details.

Harbormaster completed remote builds in B11207: Diff 10139.Mar 18 2020, 6:24 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

6 lines

Diff 10141

View Options

Don't count origins len(url) times when calling origin_add_oneClosedPublicActions