Don't create a transaction for content_get_partition
ClosedPublic
Actions

Authored by olasd on Mar 18 2020, 12:06 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTO1dbb732622b6: Don't create a transaction for content_get_partition

Summary

It just calls out to another function which, itself, creates a transaction.

Test Plan

tox tests unchanged

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 18 2020, 12:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2020, 12:06 PM

To be consistent with other methods, you could pass db and cur, but that works too

This revision is now accepted and ready to land.Mar 18 2020, 12:26 PM

In D2844#68389, @vlorentz wrote:

To be consistent with other methods, you could pass db and cur, but that works too

That's fair. In that case, I erred on the side of minimizing the size of the db transaction.

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1066/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1066/console

Harbormaster failed remote builds in B11184: Diff 10115!Mar 18 2020, 12:46 PM

Yeah, and it spares a transaction creation in case of invalid arguments

This revision was landed with ongoing or failed builds.Mar 18 2020, 12:52 PM

Closed by commit rDSTO1dbb732622b6: Don't create a transaction for content_get_partition (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO1dbb732622b6: Don't create a transaction for content_get_partition.

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

3 lines

Diff 10121

View Options

Don't create a transaction for content_get_partitionClosedPublicActions