Page MenuHomeSoftware Heritage

Remove extra 'perms' key of contents when replaying.
ClosedPublic

Authored by vlorentz on Mon, Mar 16, 4:29 PM.

Details

Summary

It crashes when the dict is converted to an swh-model object.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mon, Mar 16, 4:29 PM
ardumont accepted this revision.Mon, Mar 16, 6:08 PM
This revision is now accepted and ready to land.Mon, Mar 16, 6:08 PM
ardumont requested changes to this revision.Tue, Mar 17, 10:12 AM

I accepted, re-read and see we are missing type on the new function.
Please add them first ;)

swh/journal/replay.py
71

type!

This revision now requires changes to proceed.Tue, Mar 17, 10:12 AM
vlorentz updated this revision to Diff 10094.Tue, Mar 17, 10:18 AM

add annotation

ardumont accepted this revision.Tue, Mar 17, 10:35 AM
This revision is now accepted and ready to land.Tue, Mar 17, 10:35 AM
This revision was automatically updated to reflect the committed changes.