Differential D2836

Remove extra 'perms' key of contents when replaying.
ClosedPublic
Actions

Authored by vlorentz on Mar 16 2020, 4:29 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNL4ce176266779: Remove extra 'perms' key of contents when replaying.

Summary

It crashes when the dict is converted to an swh-model object.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 16 2020, 4:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 16 2020, 4:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/398/ for more details.

Harbormaster completed remote builds in B11155: Diff 10086.Mar 16 2020, 4:33 PM

ardumont accepted this revision.Mar 16 2020, 6:08 PM

This revision is now accepted and ready to land.Mar 16 2020, 6:08 PM

I accepted, re-read and see we are missing type on the new function.
Please add them first ;)

swh/journal/replay.py
70	type!

This revision now requires changes to proceed.Mar 17 2020, 10:12 AM

add annotation

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/399/ for more details.

Harbormaster completed remote builds in B11163: Diff 10094.Mar 17 2020, 10:22 AM

ardumont accepted this revision.Mar 17 2020, 10:35 AM

This revision is now accepted and ready to land.Mar 17 2020, 10:35 AM

Closed by commit rDJNL4ce176266779: Remove extra 'perms' key of contents when replaying. (authored by vlorentz). · Explain WhyMar 17 2020, 10:38 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDJNL4ce176266779: Remove extra 'perms' key of contents when replaying..

Revision Contents
Changeset List

Path

Size

swh/

journal/

replay.py

19 lines

Diff 10095

View Options

Remove extra 'perms' key of contents when replaying.ClosedPublicActions