Page MenuHomeSoftware Heritage

swh.web.settings.production: Fix mypy warning
ClosedPublic

Authored by ardumont on Mon, Mar 16, 1:00 PM.

Details

Summary
Test Plan

tox -e mypy

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mon, Mar 16, 1:00 PM
ardumont edited the summary of this revision. (Show Details)Mon, Mar 16, 1:02 PM
ardumont added a comment.EditedMon, Mar 16, 1:06 PM

Build has FAILED

lol, yeah, i tagged swh.storage v0.0.178
now it needs D2830 to work...

anlambert accepted this revision.Mon, Mar 16, 1:13 PM
This revision is now accepted and ready to land.Mon, Mar 16, 1:13 PM

I do not understand why the CI builds fail. Looks like parent diff is not applied but it should.

Oh I got it, the diff is not rebased on D2830

Oh I got it, the diff is not rebased on D2830

oh yeah! oops. Thanks.

vlorentz requested changes to this revision.Mon, Mar 16, 2:28 PM
vlorentz added a subscriber: vlorentz.

Why not set the type of REST_FRAMEWORK to Dict[str, Any] in common.py?

This revision now requires changes to proceed.Mon, Mar 16, 2:28 PM
ardumont updated this revision to Diff 10072.Mon, Mar 16, 2:42 PM

Fix the initial definition source as it's even more reasonable

Yes, better thanks.
I thought it was an original dict defined earlier in the django stanza internals.

Thanks.

ardumont retitled this revision from swh.web.settings.production: Ignore mypy warning to swh.web.settings.production: Fix mypy warning.Mon, Mar 16, 2:43 PM
ardumont edited the summary of this revision. (Show Details)
vlorentz accepted this revision.Mon, Mar 16, 2:46 PM
This revision is now accepted and ready to land.Mon, Mar 16, 2:46 PM
This revision was automatically updated to reflect the committed changes.