Page MenuHomeSoftware Heritage
Differential D2831

indexer.tests: Migrate to latest swh-storage api change
ClosedPublic
Actions

Authored by ardumont on Mar 14 2020, 11:41 AM.

Details

Reviewers
anlambert
vlorentz
Group Reviewers
Reviewers
Commits
rDCIDXdb6acb9a7e44: tests: Migrate to latest swh-storage api change
Summary

Related to D2820

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 14 2020, 11:41 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 14 2020, 11:41 AM
ardumont mentioned this in D2820: storage: origin_visit_add: Type and make origin_visit_add return an OriginVisit object.Mar 14 2020, 11:42 AM
swh-public-ci added a comment.Mar 14 2020, 11:43 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/718/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/718/console

Harbormaster failed remote builds in B11132: Diff 10061!Mar 14 2020, 11:43 AM
ardumont retitled this revision from tests: Migrate to latest swh-storage api change to indexer.tests: Migrate to latest swh-storage api change.Mar 14 2020, 1:42 PM
anlambert requested changes to this revision.Mar 16 2020, 11:37 AM
anlambert added a subscriber: anlambert.

One mistake to fix but looks good.

swh/indexer/tests/test_origin_head.py
103

visit.visit

This revision now requires changes to proceed.Mar 16 2020, 11:37 AM
ardumont added inline comments.Mar 16 2020, 11:41 AM
swh/indexer/tests/test_origin_head.py
103

ugh, right!

ardumont updated this revision to Diff 10063.Mar 16 2020, 12:35 PM

Fix

swh-public-ci added a comment.Mar 16 2020, 12:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/719/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/719/console

Harbormaster failed remote builds in B11134: Diff 10063!Mar 16 2020, 12:37 PM
vlorentz accepted this revision.Mar 16 2020, 12:55 PM
anlambert accepted this revision.Mar 16 2020, 1:13 PM
This revision is now accepted and ready to land.Mar 16 2020, 1:13 PM
swh-public-ci added a comment.Mar 16 2020, 1:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/720/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/720/console

ardumont updated this revision to Diff 10079.Mar 16 2020, 3:15 PM

Fix

swh-public-ci added a comment.Mar 16 2020, 3:17 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/721/ for more details.

Harbormaster completed remote builds in B11148: Diff 10079.Mar 16 2020, 3:17 PM
ardumont edited the summary of this revision. (Show Details)Mar 16 2020, 3:19 PM
Closed by commit rDCIDXdb6acb9a7e44: tests: Migrate to latest swh-storage api change (authored by ardumont). · Explain WhyMar 16 2020, 3:19 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDCIDXdb6acb9a7e44: tests: Migrate to latest swh-storage api change.

Revision Contents
Changeset List

PathSize
1 line
swh/
indexer/
tests/
4 lines
4 lines

Diff 10080

View Options

requirements-test.txt

Loading...
View Options

swh/indexer/tests/test_origin_head.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal