Page MenuHomeSoftware Heritage
Differential D2828

loader-core: Migrate to latest storage.origin_visit_add api change
ClosedPublic
Actions

Authored by ardumont on Mar 14 2020, 11:18 AM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLDBASE4dfeafac9f81: Migrate to latest storage.origin_visit_add api change
Summary

Related to D2820

Note: Test will fail as long as storage is not tagged (monday)

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11129
Build 16784: tox-on-jenkinsJenkins
Build 16783: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 14 2020, 11:18 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 14 2020, 11:18 AM
swh-public-ci added a comment.Mar 14 2020, 11:19 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/358/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/358/console

Harbormaster failed remote builds in B11129: Diff 10058!Mar 14 2020, 11:19 AM
ardumont mentioned this in D2829: loader-svn: Migrate to latest swh-loader-core api change.Mar 14 2020, 11:23 AM
ardumont mentioned this in D2820: storage: origin_visit_add: Type and make origin_visit_add return an OriginVisit object.Mar 14 2020, 11:31 AM
ardumont retitled this revision from Migrate to latest storage.origin_visit_add api change to loader-core: Migrate to latest storage.origin_visit_add api change.Mar 14 2020, 11:38 AM
anlambert accepted this revision.Mar 16 2020, 11:42 AM
anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Mar 16 2020, 11:42 AM
swh-public-ci added a comment.Mar 16 2020, 1:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/359/ for more details.

Harbormaster completed remote builds in B11129: Diff 10058.Mar 16 2020, 1:07 PM
Closed by commit rDLDBASE4dfeafac9f81: Migrate to latest storage.origin_visit_add api change (authored by ardumont). · Explain WhyMar 16 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASE4dfeafac9f81: Migrate to latest storage.origin_visit_add api change.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
core/
12 lines
tests/
5 lines
package/
8 lines

Diff 10058

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
View Options

swh/loader/package/loader.py

Loading...
About · Developer information · Legal