Page MenuHomeSoftware Heritage

swh-schema.sql: improve comments on revision columns
ClosedPublic

Authored by zack on Mar 12 2020, 5:56 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz added a subscriber: vlorentz.

Could you also add a migration, so they can be applied to the existing DB? (you just need to copy-paste this to a new file in sql/upgrades/ and increment the version number)

This revision now requires changes to proceed.Mar 12 2020, 6:36 PM

Could you also add a migration, so they can be applied to the existing DB?

Indeed, that must be why those comments are not currently in the production db in the first place.
We missed that part when deploying the version.

Those are actually already applied in db.
So i guess, remains to land this as is (it's no longer in need of a migration script).

This revision is now accepted and ready to land.May 7 2020, 3:49 PM