Differential D2816

tests/models: use d.copy() instead of dict(d)
ClosedPublic
Actions

Authored by douardda on Mar 11 2020, 5:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODc74696036e97: tests/models: use d.copy() instead of dict(d)

Summary

for better clarity on the code author's intention.

Test Plan

Depends on D2815.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 11 2020, 5:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 11 2020, 5:54 PM

douardda added a child revision: D2817: test/model: do not test direct instanciation of model objects.Mar 11 2020, 5:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/211/ for more details.

Harbormaster completed remote builds in B11079: Diff 10007.Mar 11 2020, 5:55 PM

ardumont accepted this revision.Mar 11 2020, 7:52 PM

This revision is now accepted and ready to land.Mar 11 2020, 7:52 PM

Closed by commit rDMODc74696036e97: tests/models: use d.copy() instead of dict(d) (authored by douardda). · Explain WhyMar 12 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMODc74696036e97: tests/models: use d.copy() instead of dict(d).

Revision Contents
Changeset List

Path

Size

swh/

model/

tests/

test_model.py

10 lines

Diff 10022

View Options

swh/model/tests/test_model.py

tests/models: use d.copy() instead of dict(d)ClosedPublicActions