Paths

Table of Contentst

Differential D2811

scanner: added test for the model
ClosedPublic
Actions

Authored by DanSeraf on Mar 11 2020, 2:57 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDTSCN3d462c8364ed: added test for the model
rDTSCN8448ae0a840e: get_subpaths test adapted to the new temp_folder structure
rDTSCN3de533865fef: changed folder structure in temp_folder fixture

Summary

model test:

addNode: assert each node is correctly added in the tree structure
getJsonTree: assert the result is coherent with the data stored in the tree structure

The folder structure in the fixture temp_folder has changed to be used also by the model tests.

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Mar 11 2020, 2:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 11 2020, 2:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/15/ for more details.

Harbormaster completed remote builds in B11069: Diff 9997.Mar 11 2020, 2:58 PM

vlorentz requested changes to this revision.Mar 12 2020, 2:10 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/scanner/tests/conftest.py
44–50	Use a code block, or it will have formatting issues in our Sphinx-generated docs

This revision now requires changes to proceed.Mar 12 2020, 2:10 PM

douardda added a subscriber: douardda.Mar 12 2020, 2:15 PM

douardda added inline comments.

swh/scanner/tests/conftest.py
41	generates
56	The PosixPath is not needed here (and below): subfile = root.joinpath('subfile1.txt') or even: subfile = root / 'subfile1.txt'

changes

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/16/ for more details.

Harbormaster completed remote builds in B11104: Diff 10033.Mar 12 2020, 6:04 PM

vlorentz accepted this revision.Mar 12 2020, 6:36 PM

This revision is now accepted and ready to land.Mar 12 2020, 6:36 PM

Closed by commit rDTSCN3de533865fef: changed folder structure in temp_folder fixture (authored by DanSeraf). · Explain WhyMar 12 2020, 6:42 PM

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCN3de533865fef: changed folder structure in temp_folder fixture.

DanSeraf added a commit: rDTSCN8448ae0a840e: get_subpaths test adapted to the new temp_folder structure.

DanSeraf added a commit: rDTSCN3d462c8364ed: added test for the model.

Revision Contents
Changeset List

Path

Size

swh/

scanner/

tests/

conftest.py

36 lines

Diff 10035

View Options

swh/scanner/tests/conftest.py

scanner: added test for the modelClosedPublicActions