Differential D2801

kafka: normalize KafkaJournalWriter.write_addition[s] API
ClosedPublic
Actions

Authored by douardda on Mar 10 2020, 4:41 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNL82df6acedbb1: kafka: normalize KafkaJournalWriter.write_addition[s] API

Summary

remove the 'flush' argument from these methods' argument list: it
does not exists in the InMemoryJournalWriter version of this
service, and it is in fact useless.

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 11034
Build 16618: tox-on-jenkins	Jenkins
Build 16617: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 10 2020, 4:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 10 2020, 4:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/369/ for more details.

Harbormaster completed remote builds in B11029: Diff 9958.Mar 10 2020, 4:44 PM

ardumont accepted this revision.Mar 10 2020, 5:23 PM

This revision is now accepted and ready to land.Mar 10 2020, 5:23 PM

remove extra parameter 'anon' mistakenly included in the diff

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/372/ for more details.

Harbormaster completed remote builds in B11034: Diff 9962.Mar 10 2020, 5:32 PM

Closed by commit rDJNL82df6acedbb1: kafka: normalize KafkaJournalWriter.write_addition[s] API (authored by douardda). · Explain WhyMar 10 2020, 5:35 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNL82df6acedbb1: kafka: normalize KafkaJournalWriter.write_addition[s] API.

Revision Contents
Changeset List

Path

Size

swh/

journal/

writer/

kafka.py

21 lines

Diff 9962

View Options

swh/journal/writer/kafka.py

kafka: normalize KafkaJournalWriter.write_addition[s] APIClosedPublicActions