Page MenuHomeSoftware Heritage

kafka: normalize KafkaJournalWriter.write_addition[s] API
ClosedPublic

Authored by douardda on Tue, Mar 10, 4:41 PM.

Details

Summary

remove the 'flush' argument from these methods' argument list: it
does not exists in the InMemoryJournalWriter version of this
service, and it is in fact useless.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Mar 10, 4:41 PM
ardumont accepted this revision.Tue, Mar 10, 5:23 PM
This revision is now accepted and ready to land.Tue, Mar 10, 5:23 PM
douardda updated this revision to Diff 9962.Tue, Mar 10, 5:29 PM

remove extra parameter 'anon' mistakenly included in the diff