Differential D2795

Add type annotations to swh.journal.client arguments
ClosedPublic
Actions

Authored by olasd on Mar 10 2020, 1:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNLfd453b4784ca: Add type annotations to swh.journal.client arguments

Test Plan

ran mypy swh, with and without --untyped-defs

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 10 2020, 1:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 10 2020, 1:51 PM

ardumont accepted this revision.Mar 10 2020, 1:53 PM

This revision is now accepted and ready to land.Mar 10 2020, 1:53 PM

olasd added a child revision: D2797: Be more careful with content generation in test_write_replay.Mar 10 2020, 1:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/362/ for more details.

Harbormaster completed remote builds in B11014: Diff 9943.Mar 10 2020, 1:55 PM

Closed by commit rDJNLfd453b4784ca: Add type annotations to swh.journal.client arguments (authored by olasd). · Explain WhyMar 10 2020, 2:13 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNLfd453b4784ca: Add type annotations to swh.journal.client arguments.

Revision Contents
Changeset List

Path

Size

swh/

journal/

client.py

19 lines

tests/

28 lines

15 lines

4 lines

4 lines

Diff 9949

View Options

swh/journal/client.py

View Options

swh/journal/tests/test_client.py

View Options

swh/journal/tests/test_replay.py

View Options

swh/journal/tests/test_write_replay.py

View Options

swh/journal/tests/utils.py

Add type annotations to swh.journal.client argumentsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9949

swh/journal/client.py

swh/journal/tests/test_client.py

swh/journal/tests/test_replay.py

swh/journal/tests/test_write_replay.py

swh/journal/tests/utils.py

Add type annotations to swh.journal.client arguments
ClosedPublic
Actions

Revision Contents
Changeset List