Differential D277

Support snapshot identifiers in swh.model
ClosedPublic
Actions

Authored by olasd on Dec 12 2017, 8:10 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Maniphest Tasks

T566: specify serialization format for repository snapshot objects

Commits

rDMOD1b1cc8d521f1: hashutil: add `snapshot` object type for git hashes
rDMOD46ce819ff675: hashutil: add `snapshot` object type for git hashes

Summary

Add support for snapshot identifiers

Close T566.
Related to D268.

Test Plan

Unit tests included

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1134
Build 1478: arc lint + arc unit

Event Timeline

olasd created this revision.Dec 12 2017, 8:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 12 2017, 8:10 PM

Harbormaster completed remote builds in B1134: Diff 933.Dec 12 2017, 8:10 PM

The format looks very good and exhaustive to me, from my microscopic understanding of the subject of course.

olasd retitled this revision from hashutil: add `snapshot` object type for git hashes to Support snapshot identifiers in swh.model.Dec 13 2017, 10:47 AM

Thumbs up for the good work!
I like it.

(well, I hate the horrible git-directory-style serialization format without separators and crazy field ordering, but I agree that is better to be consistent than having a single object type with a nice[r] serialization format)

This revision is now accepted and ready to land.Dec 13 2017, 10:54 AM

Closed by commit rDMOD46ce819ff675: hashutil: add `snapshot` object type for git hashes (authored by olasd). · Explain WhyDec 13 2017, 11:30 AM

This revision was automatically updated to reflect the committed changes.