Differential D2763

Actually document the new flag for process_replay_objects_contents
ClosedPublic
Actions

Authored by olasd on Mar 3 2020, 4:45 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDJNL8daf401d52b6: Actually document the new flag for process_replay_objects_contents

Summary

Replaces docstring annotations with type annotations as well

Depends on D2762. (not really but test speedups are Good)

Test Plan

mypy is still happy (there was a bug in the Callable docstring "type"
annotation, that it caught)

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 3 2020, 4:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 3 2020, 4:45 PM

vlorentz accepted this revision.Mar 3 2020, 4:46 PM

This revision is now accepted and ready to land.Mar 3 2020, 4:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/347/ for more details.

Harbormaster completed remote builds in B10886: Diff 9828.Mar 3 2020, 4:50 PM

Closed by commit rDJNL8daf401d52b6: Actually document the new flag for process_replay_objects_contents (authored by olasd). · Explain WhyMar 4 2020, 5:05 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNL8daf401d52b6: Actually document the new flag for process_replay_objects_contents.

Revision Contents
Changeset List

Path

Size

swh/

journal/

replay.py

27 lines

Diff 9847

View Options

Actually document the new flag for process_replay_objects_contentsClosedPublicActions