Differential D2726

svn.converters: Clean up dead code
ClosedPublic
Actions

Authored by ardumont on Feb 28 2020, 10:25 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDSVN1b98cfa7d904: converters: Clean up dead code

Summary

This was used in early versions when we had both a svn and a git-svn loader
implementation (for comparison purposes). The git-svn loader is long gone now
so might as well cleanup this as well.

Depends on D2725

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10796
Build 16210: tox-on-jenkins	Jenkins
Build 16209: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 28 2020, 10:25 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 28 2020, 10:25 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/65/console

Harbormaster failed remote builds in B10790: Diff 9721!Feb 28 2020, 10:26 AM

Build has FAILED

barf...
"java.lang.OutOfMemoryError: unable to create native thread: possibly out of memory or process/resource limits reached"
sure, that won't help.

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/66/ for more details.

Harbormaster completed remote builds in B10790: Diff 9721.Feb 28 2020, 10:34 AM

vlorentz accepted this revision.Feb 28 2020, 11:44 AM

This revision is now accepted and ready to land.Feb 28 2020, 11:44 AM

Rebase and plug to latest master

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/68/ for more details.

Harbormaster completed remote builds in B10796: Diff 9725.Feb 28 2020, 12:02 PM

Closed by commit rDLDSVN1b98cfa7d904: converters: Clean up dead code (authored by ardumont). · Explain WhyFeb 28 2020, 12:03 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN1b98cfa7d904: converters: Clean up dead code.