Page MenuHomeSoftware Heritage
Differential D2725

svn.loader: Fix latest swh.model.from_disk api change in loader
ClosedPublic
Actions

Authored by ardumont on Feb 28 2020, 10:14 AM.

Details

Reviewers
vlorentz
olasd
Group Reviewers
Reviewers
Commits
rDLDSVN6447cfc9498e: svn.loader: Fix latest swh.model.from_disk api change in loader
Summary

Prior to this commit, the api change break the current loader implementation.
This fixes it by simply adapting the api calls. This will unbreak the current
ci build failure [1]

[1] https://jenkins.softwareheritage.org/job/DLDSVN/job/tests/536/console

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10793
Build 16205: tox-on-jenkinsJenkins
Build 16204: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 28 2020, 10:14 AM
ardumont updated this revision to Diff 9720.Feb 28 2020, 10:16 AM

Remove typo

swh-public-ci added a comment.Feb 28 2020, 10:20 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/63/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/63/console

Harbormaster failed remote builds in B10788: Diff 9719!Feb 28 2020, 10:20 AM
ardumont added a child revision: D2726: svn.converters: Clean up dead code.Feb 28 2020, 10:25 AM
swh-public-ci added a comment.Feb 28 2020, 10:26 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/64/ for more details.

Harbormaster completed remote builds in B10789: Diff 9720.Feb 28 2020, 10:26 AM
vlorentz accepted this revision.Feb 28 2020, 11:43 AM
This revision is now accepted and ready to land.Feb 28 2020, 11:43 AM
ardumont updated this revision to Diff 9722.Feb 28 2020, 11:48 AM

Plug to master

swh-public-ci added a comment.Feb 28 2020, 11:54 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/67/ for more details.

Harbormaster completed remote builds in B10793: Diff 9722.Feb 28 2020, 11:54 AM
Closed by commit rDLDSVN6447cfc9498e: svn.loader: Fix latest swh.model.from_disk api change in loader (authored by ardumont). · Explain WhyFeb 28 2020, 11:55 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVN6447cfc9498e: svn.loader: Fix latest swh.model.from_disk api change in loader.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
svn/
23 lines
5 lines
11 lines

Diff 9722

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/svn/loader.py

Loading...
View Options

swh/loader/svn/ra.py

Loading...
View Options

swh/loader/svn/svn.py

Loading...
About · Developer information · Legal