Differential D2724

Use Content.hashes() instead of Content.to_dict() where it makes sense.
ClosedPublic
Actions

Authored by vlorentz on Feb 27 2020, 5:00 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO522235252687: Use Content.hashes() instead of Content.to_dict() where it makes sense.

Summary

.hashes() returns a subset of .to_dict(), so it was accidentally used instead.

Diff Detail

Repository

rDSTO Storage manager

Branch

hashes-dict

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10786
Build 16194: tox-on-jenkins	Jenkins
Build 16193: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 27 2020, 5:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 27 2020, 5:00 PM

ardumont accepted this revision.Feb 27 2020, 5:46 PM

This revision is now accepted and ready to land.Feb 27 2020, 5:46 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1010/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1010/console

Harbormaster failed remote builds in B10786: Diff 9718!Feb 28 2020, 10:33 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1011/ for more details.

Harbormaster completed remote builds in B10786: Diff 9718.Feb 28 2020, 11:56 AM

Closed by commit rDSTO522235252687: Use Content.hashes() instead of Content.to_dict() where it makes sense. (authored by vlorentz). · Explain WhyFeb 28 2020, 2:43 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO522235252687: Use Content.hashes() instead of Content.to_dict() where it makes sense..

Revision Contents
Changeset List

Path

Size

swh/

storage/

filter.py

4 lines

in_memory.py

2 lines

Diff 9718

View Options

swh/storage/filter.py