Differential D2697

Move revision loading logic to its own function.
ClosedPublic
Actions

Authored by vlorentz on Feb 19 2020, 5:49 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDBASE384f1d302f95: Move revision loading logic to its own function.

Summary

PackageLoader.load() was way too long and nested.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

split-load-revision

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10700
Build 16048: tox-on-jenkins	Jenkins
Build 16047: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 19 2020, 5:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 19 2020, 5:49 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/332/ for more details.

Harbormaster completed remote builds in B10700: Diff 9636.Feb 19 2020, 5:55 PM

anlambert accepted this revision.Feb 20 2020, 4:46 PM

This revision is now accepted and ready to land.Feb 20 2020, 4:46 PM

Closed by commit rDLDBASE384f1d302f95: Move revision loading logic to its own function. (authored by vlorentz). · Explain WhyFeb 24 2020, 12:18 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE384f1d302f95: Move revision loading logic to its own function..

Revision Contents
Changeset List

Path

Size

swh/

loader/

package/

loader.py

142 lines

Diff 9636

View Options

swh/loader/package/loader.py

Move revision loading logic to its own function.ClosedPublicActions