Differential D2644

Add type annotations to swh.core.api
ClosedPublic
Actions

Authored by legau on Feb 10 2020, 5:06 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2256: Add type annotations to swh.core.api

Commits

rDCOREfbc81cca0551: Add type annotations to swh.core.api

Summary

Fixed consistency problems

Optional params are now Optional

Data is now bytes

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

legau created this revision.Feb 10 2020, 5:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 10 2020, 5:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/403/ for more details.

Harbormaster completed remote builds in B10525: Diff 9463.Feb 10 2020, 5:08 PM

Data is now bytes and commits are squashed

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/404/ for more details.

Harbormaster completed remote builds in B10526: Diff 9464.Feb 10 2020, 5:14 PM

legau added a task: T2256: Add type annotations to swh.core.api.Feb 10 2020, 5:28 PM

legau added a parent revision: D2636: Add type annotations to swh.core.api.

legau added a reviewer: vlorentz.Feb 10 2020, 5:32 PM

vlorentz accepted this revision.Feb 11 2020, 10:24 AM

This revision is now accepted and ready to land.Feb 11 2020, 10:24 AM

Thanks!

Closed by commit rDCOREfbc81cca0551: Add type annotations to swh.core.api (authored by legau). · Explain WhyFeb 11 2020, 2:13 PM

This revision was automatically updated to reflect the committed changes.

legau added a commit: rDCOREfbc81cca0551: Add type annotations to swh.core.api.

Revision Contents
Changeset List

Path

Size

swh/

core/

api/

negotiation.py

44 lines

serializers.py

19 lines

Diff 9471

View Options

swh/core/api/negotiation.py