This will simplify this computation done storage side.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDOBJS18020c3a56b3: objstorage: Return summary of batched object added to the store
tox
Diff Detail
Diff Detail
- Repository
- rDOBJS Object storage
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/101/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/102/ for more details.
| swh/objstorage/multiplexer/multiplexer_objstorage.py | ||
|---|---|---|
| 248–262 | @olasd mentionned using a Counter, to get shorter code. I think it could work like this: results = self.wrap_call(
write_threads, 'add_batch', contents,
check_presence=check_presence,
)
summed = sum(results)
return {
'object:add': summed['object:add'] // len(results),
'object:add:bytes': summed['object:add:bytes'] // len(results),
} | |
| swh/objstorage/multiplexer/multiplexer_objstorage.py | ||
|---|---|---|
| 248–262 | also, s/result/results in the sum | |
Comment Actions
Fix
| swh/objstorage/multiplexer/multiplexer_objstorage.py | ||
|---|---|---|
| 248–262 | yeah... that's the real issue here ;) | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/103/ for more details.