Page MenuHomeSoftware Heritage

Allow deprecated endpoints to be missing from a backend class.
ClosedPublic

Authored by vlorentz on Wed, Jan 29, 4:17 PM.

Details

Summary

Needed for the Cassandra backend, which doesn't implement them.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Jan 29, 4:17 PM
anlambert accepted this revision.Wed, Jan 29, 4:43 PM
anlambert added a subscriber: anlambert.

Looks good !

swh/storage/interface.py
1182

I think we can later safely remove those endpoints from the storage interface as only the webapp use diff features and it now relies on the function located in swh.storage.algos.diff instead of those storage methods.

This revision is now accepted and ready to land.Wed, Jan 29, 4:43 PM
vlorentz updated this revision to Diff 9301.Wed, Jan 29, 4:49 PM

fix typo

This revision was landed with ongoing or failed builds.Wed, Jan 29, 4:50 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added inline comments.Wed, Jan 29, 4:50 PM
swh/storage/interface.py
1182

will do