Page MenuHomeSoftware Heritage
Differential D2601

Allow deprecated endpoints to be missing from a backend class.
ClosedPublic
Actions

Authored by vlorentz on Jan 29 2020, 4:17 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDSTO1608fcd51f19: Allow deprecated endpoints to be missing from a backend class.
Summary

Needed for the Cassandra backend, which doesn't implement them.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 29 2020, 4:17 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2020, 4:17 PM
vlorentz mentioned this in D2566: Add Cassandra backend..Jan 29 2020, 4:17 PM
vlorentz added a child revision: D2566: Add Cassandra backend..Jan 29 2020, 4:18 PM
swh-public-ci added a comment.Jan 29 2020, 4:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/930/ for more details.

Harbormaster completed remote builds in B10358: Diff 9298.Jan 29 2020, 4:20 PM
anlambert accepted this revision.Jan 29 2020, 4:43 PM
anlambert added a subscriber: anlambert.

Looks good !

swh/storage/interface.py
1181

I think we can later safely remove those endpoints from the storage interface as only the webapp use diff features and it now relies on the function located in swh.storage.algos.diff instead of those storage methods.

This revision is now accepted and ready to land.Jan 29 2020, 4:43 PM
vlorentz updated this revision to Diff 9301.Jan 29 2020, 4:49 PM

fix typo

vlorentz updated this revision to Diff 9302.Jan 29 2020, 4:50 PM

rebase

This revision was landed with ongoing or failed builds.Jan 29 2020, 4:50 PM
Closed by commit rDSTO1608fcd51f19: Allow deprecated endpoints to be missing from a backend class. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTO1608fcd51f19: Allow deprecated endpoints to be missing from a backend class..
vlorentz added inline comments.Jan 29 2020, 4:50 PM
swh/storage/interface.py
1181

will do

Harbormaster failed remote builds in B10361: Diff 9301!Jan 29 2020, 5:03 PM
swh-public-ci added a comment.Jan 29 2020, 5:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/934/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/934/console

Harbormaster failed remote builds in B10362: Diff 9302!Jan 29 2020, 5:03 PM
swh-public-ci added a comment.Jan 29 2020, 5:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/935/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/935/console

Revision Contents
Changeset List

PathSize
swh/
storage/
11 lines
tests/
4 lines

Diff 9303

View Options

swh/storage/interface.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal