Differential D2568

Remove redundant config checks in load_and_check_config.
ClosedPublic
Actions

Authored by vlorentz on Jan 22 2020, 12:25 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOcfee7b519bb0: Remove redundant config checks in load_and_check_config.

Summary

There is no reason to force the server to serve only the 'local' backend anymore
Missing arguments will error when instantiating the backend class.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 22 2020, 12:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 22 2020, 12:25 PM

vlorentz mentioned this in D2566: Add Cassandra backend..Jan 22 2020, 12:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/871/ for more details.

Harbormaster completed remote builds in B10228: Diff 9165.Jan 22 2020, 12:28 PM

vlorentz added a child revision: D2566: Add Cassandra backend..Jan 22 2020, 12:29 PM

looks good to me

This revision is now accepted and ready to land.Jan 22 2020, 2:47 PM

Closed by commit rDSTOcfee7b519bb0: Remove redundant config checks in load_and_check_config. (authored by vlorentz). · Explain WhyJan 22 2020, 2:49 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOcfee7b519bb0: Remove redundant config checks in load_and_check_config..

Revision Contents
Changeset List

Path

Size

swh/

storage/

api/

14 lines

tests/

44 lines

Diff 9175

swh/storage/api/server.py

Loading...

swh/storage/tests/test_server.py

Loading...