github.lister: Use Retry-After header when rate limit reached
ClosedPublic
Actions

Authored by ardumont on Jan 16 2020, 6:48 PM.

Details

Reviewers

olasd
vlorentz

Group Reviewers

Reviewers

Commits

rDLS4b383abc5650: github.lister: Use Retry-After header when rate limit reached

Summary

Following the documentation:
[1] https://developer.github.com/v3/guides/best-practices-for-integrators/#dealing-with-abuse-rate-limits

This does not deal with the concurrency aspect.
For that part, the goal is to deploy the github lister on 1 dedicated worker for now (done puppet side and deployed, worker01 got elected).

Related to T2170

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 16 2020, 6:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/532/ for more details.

Harbormaster completed remote builds in B10161: Diff 9098.Jan 16 2020, 6:52 PM

ardumont retitled this revision from github.lister: Simplify rate limit approach according to github doc to github.lister: Use Retry-After header when rate limit reached.Jan 17 2020, 10:36 AM

ardumont edited the summary of this revision. (Show Details)Jan 17 2020, 12:02 PM

ardumont edited the summary of this revision. (Show Details)

vlorentz accepted this revision.Jan 17 2020, 1:49 PM

This revision is now accepted and ready to land.Jan 17 2020, 1:49 PM

Plug to master branch

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/535/ for more details.

Harbormaster completed remote builds in B10170: Diff 9103.Jan 17 2020, 2:19 PM

Closed by commit rDLS4b383abc5650: github.lister: Use Retry-After header when rate limit reached (authored by ardumont). · Explain WhyJan 17 2020, 2:20 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS4b383abc5650: github.lister: Use Retry-After header when rate limit reached.