Differential D2528

test_replay: Migrate to latest content_get_metadata api change
ClosedPublic
Actions

Authored by ardumont on Jan 14 2020, 4:47 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDJNL30b2d0ca3904: test_replay: Migrate to latest content_get_metadata api change

Summary

Related to D2522

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10121
Build 15009: tox-on-jenkins	Jenkins
Build 15008: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 14 2020, 4:47 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 14 2020, 4:47 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/320/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/320/console

Harbormaster failed remote builds in B10096: Diff 8996!Jan 14 2020, 4:50 PM

ardumont edited the summary of this revision. (Show Details)Jan 14 2020, 5:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/321/ for more details.

Harbormaster completed remote builds in B10096: Diff 8996.Jan 14 2020, 5:37 PM

vlorentz accepted this revision.Jan 15 2020, 2:02 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/journal/tests/test_replay.py
111	assert contents == {cont['sha1']: cont for cont in input_contents} will also check there are no extra data (it's unlikely to happen, but it doesn't hurt to check it)

This revision is now accepted and ready to land.Jan 15 2020, 2:02 PM

Improve assertion as per review suggestion

swh/journal/tests/test_replay.py
111	assert contents == {cont['sha1']: [cont] for cont in input_contents} will adapt

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/322/ for more details.

Harbormaster completed remote builds in B10121: Diff 9019.Jan 15 2020, 3:00 PM

Closed by commit rDJNL30b2d0ca3904: test_replay: Migrate to latest content_get_metadata api change (authored by ardumont). · Explain WhyJan 15 2020, 3:00 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDJNL30b2d0ca3904: test_replay: Migrate to latest content_get_metadata api change.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

9 lines

Diff 9019

swh/journal/tests/test_replay.py

Loading...