Differential D2506

read: use shutil.make_archive directly to generate the zip file
ClosedPublic
Actions

Authored by douardda on Jan 8 2020, 1:24 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP90a5072b1f78: api/private/read: use shutil.make_archive directly to generate the zip file

Summary

this code was the only user for the swh.core.tarball.compress function. Doing
so allows to reduce a bit the complexity and coupligin in the code. It will also
allow to get rid of the swh.core.tarball.compress function.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 8 2020, 1:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 8 2020, 1:24 PM

douardda added a child revision: D2507: api/private/read: use application/zip as content_type.Jan 8 2020, 1:25 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/245/ for more details.

Harbormaster completed remote builds in B10005: Diff 8905.Jan 8 2020, 1:28 PM

vlorentz accepted this revision.Jan 8 2020, 2:05 PM

This revision is now accepted and ready to land.Jan 8 2020, 2:05 PM

Closed by commit rDDEP90a5072b1f78: api/private/read: use shutil.make_archive directly to generate the zip file (authored by douardda). · Explain WhyJan 8 2020, 3:48 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDDEP90a5072b1f78: api/private/read: use shutil.make_archive directly to generate the zip file.

Revision Contents
Changeset List

Path

Size

swh/

deposit/

api/

private/

deposit_read.py

8 lines

tests/

api/

test_deposit_private_read_archive.py

49 lines

Diff 8907

View Options

swh/deposit/api/private/deposit_read.py