Differential D2482

Use a single function to format output, and remove space in metric name.
ClosedPublic
Actions

Authored by vlorentz on Dec 19 2019, 7:21 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDICP37ab8237f573: Use a single function to format output, and remove space in metric name.

Summary

print_result deduplicates code a bit; and replacing the space with
an underscore is recommended by Icinga's documentation.

Diff Detail

Repository

rDICP Icinga plugins

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 19 2019, 7:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 19 2019, 7:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DICP/job/tox/14/ for more details.

Harbormaster completed remote builds in B9913: Diff 8820.Dec 19 2019, 7:22 PM

vlorentz added a child revision: D2483: Simplify CLI options handling, and move --swh-storage-url and --swh-web-url to the check_vault subcommand..Dec 19 2019, 7:23 PM

olasd accepted this revision.Jan 2 2020, 3:48 PM

This revision is now accepted and ready to land.Jan 2 2020, 3:48 PM

Closed by commit rDICP37ab8237f573: Use a single function to format output, and remove space in metric name. (authored by vlorentz). · Explain WhyJan 6 2020, 12:06 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDICP37ab8237f573: Use a single function to format output, and remove space in metric name..

Revision Contents
Changeset List

Path

Size

swh/

icinga_plugins/

base_check.py

5 lines

tests/

test_vault.py

8 lines

vault.py

41 lines

Diff 8855

View Options

swh/icinga_plugins/base_check.py

View Options

swh/icinga_plugins/tests/test_vault.py

View Options

swh/icinga_plugins/vault.py

Use a single function to format output, and remove space in metric name.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8855

swh/icinga_plugins/base_check.py

swh/icinga_plugins/tests/test_vault.py

swh/icinga_plugins/vault.py

Use a single function to format output, and remove space in metric name.
ClosedPublic
Actions

Revision Contents
Changeset List