Page MenuHomeSoftware Heritage
Differential D2469

Clean temporary file handling for metadata generation, and add test.
ClosedPublic
Actions

Authored by vlorentz on Dec 18 2019, 6:32 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEP05be3e60fa59: Clean temporary file handling for metadata generation, and add test.
Summary

This uses a context-manager instead of manually handling
removing the file.

Depends on D2465.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 18 2019, 6:32 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 18 2019, 6:32 PM
Harbormaster failed remote builds in B9866: Diff 8769!Dec 18 2019, 6:33 PM
swh-public-ci added a comment.Dec 18 2019, 6:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/215/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/215/console

vlorentz added a child revision: D2470: Improve validation of --author and --name..Dec 18 2019, 6:54 PM
swh-public-ci added a comment.Dec 18 2019, 7:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/220/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/220/console

swh-public-ci added a comment.Dec 18 2019, 7:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/223/ for more details.

Harbormaster completed remote builds in B9866: Diff 8769.Dec 18 2019, 7:12 PM
ardumont accepted this revision.Dec 19 2019, 9:10 AM
This revision is now accepted and ready to land.Dec 19 2019, 9:10 AM
vlorentz updated this revision to Diff 8802.Dec 19 2019, 3:00 PM

rebase

Harbormaster failed remote builds in B9895: Diff 8802!Dec 19 2019, 3:00 PM
swh-public-ci added a comment.Dec 19 2019, 3:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/232/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/232/console

swh-public-ci added a comment.Dec 19 2019, 3:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/233/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/233/console

vlorentz edited parent revisions, added: D2464: Start writing tests for the deposit upload CLI.; removed: D2465: Consider the absence of --partial as an actionable command..Dec 19 2019, 3:02 PM
swh-public-ci added a comment.Dec 19 2019, 3:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/235/ for more details.

Harbormaster completed remote builds in B9895: Diff 8802.Dec 19 2019, 3:05 PM
Closed by commit rDDEP05be3e60fa59: Clean temporary file handling for metadata generation, and add test. (authored by vlorentz). · Explain WhyDec 19 2019, 3:11 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP05be3e60fa59: Clean temporary file handling for metadata generation, and add test..

Revision Contents
Changeset List

PathSize
swh/
deposit/
cli/
141 lines
tests/
cli/
47 lines

Diff 8805

View Options

swh/deposit/cli/client.py

Loading...
View Options

swh/deposit/tests/cli/test_client.py

Loading...
About · Developer information · Legal