Differential D2451

Always return a 200 status code in badge endpoints
ClosedPublic
Actions

Authored by anlambert on Dec 13 2019, 2:01 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2146: Create error badge for repositories that are not found in SWH

Commits

rDWAPPSedd7d9b68cc3: misc: Always return a 200 status code in badge endpoints

Summary

This will prevent GitHub for rendering a broken badge when an origin has not
yet been archived (a red badge with an error message is expected instead).

Related to T2146

Diff Detail

Repository

rDWAPPS Web applications

Branch

fix-badge-endpoints-status-code

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9751
Build 14384: Cypress tests for swh-web diffs	Jenkins
Build 14383: tox-on-jenkins	Jenkins
Build 14382: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 13 2019, 2:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 13 2019, 2:01 PM

anlambert edited the summary of this revision. (Show Details)Dec 13 2019, 2:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/853/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/452/ for more details.

Harbormaster completed remote builds in B9751: Diff 8662.Dec 13 2019, 2:14 PM

vlorentz accepted this revision.Dec 13 2019, 2:20 PM

This revision is now accepted and ready to land.Dec 13 2019, 2:20 PM

Closed by commit rDWAPPSedd7d9b68cc3: misc: Always return a 200 status code in badge endpoints (authored by anlambert). · Explain WhyDec 13 2019, 2:24 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSedd7d9b68cc3: misc: Always return a 200 status code in badge endpoints.

Revision Contents
Changeset List

Path

Size

swh/

web/

misc/

badges.py

6 lines

tests/

misc/

test_badges.py

40 lines

Diff 8662

View Options

swh/web/misc/badges.py