Page MenuHomeSoftware Heritage
Differential D2428

Add sentry integration to the JS code.
ClosedPublic
Actions

Authored by vlorentz on Dec 11 2019, 3:32 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T1359: Add sentry support in every swh running service
Commits
rDWAPPS6f475d1c26fb: Add sentry integration to the JS code.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 11 2019, 3:32 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 11 2019, 3:32 PM
swh-public-ci added a comment.Dec 11 2019, 3:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/846/ for more details.

vlorentz added a task: T1359: Add sentry support in every swh running service .Dec 11 2019, 3:41 PM
swh-public-ci added a comment.Dec 11 2019, 3:44 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/443/ for more details.

Harbormaster completed remote builds in B9676: Diff 8594.Dec 11 2019, 3:44 PM
anlambert added a subscriber: anlambert.Dec 11 2019, 4:54 PM
anlambert added inline comments.
swh/web/assets/src/bundles/webapp/sentry.js
12

I think you can remove the swh prefix as the compiled code is already included in a swh namespace.

anlambert requested changes to this revision.Dec 11 2019, 4:55 PM
This revision now requires changes to proceed.Dec 11 2019, 4:55 PM
vlorentz updated this revision to Diff 8697.Dec 16 2019, 3:01 PM

remove prefix

swh-public-ci added a comment.Dec 16 2019, 3:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/457/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/457/console

Harbormaster failed remote builds in B9785: Diff 8697!Dec 16 2019, 3:02 PM
swh-public-ci added a comment.Dec 16 2019, 3:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/855/ for more details.

anlambert accepted this revision.Dec 16 2019, 3:15 PM

Looks good !

This revision is now accepted and ready to land.Dec 16 2019, 3:15 PM
This revision was landed with ongoing or failed builds.Dec 16 2019, 3:20 PM
Closed by commit rDWAPPS6f475d1c26fb: Add sentry integration to the JS code. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDWAPPS6f475d1c26fb: Add sentry integration to the JS code..

Revision Contents
Changeset List

PathSize
1 line
swh/
web/
assets/
src/
bundles/
vendors/
3 lines
webapp/
1 line
21 lines
common/
8 lines
1 line
templates/
5 lines
54 lines

Diff 8701

View Options

package.json

Loading...
View Options

swh/web/assets/src/bundles/vendors/index.js

Loading...
View Options

swh/web/assets/src/bundles/webapp/index.js

Loading...
View Options

swh/web/assets/src/bundles/webapp/sentry.js

Loading...
View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/config.py

Loading...
View Options

swh/web/templates/layout.html

Loading...
View Options

yarn.lock

Loading...
About · Developer information · Legal