Page MenuHomeSoftware Heritage
Differential D2413

Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault
ClosedPublic
Actions

Authored by douardda on Dec 9 2019, 4:23 PM.

Details

Reviewers
ardumont
anlambert
Group Reviewers
Reviewers
Commits
rDENV57ab82a18cd2: Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault
Summary

It makes no sense to have -api postfixes for these 2 services only.
Plus, these are not API endpoints but RPC ones.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Dec 9 2019, 4:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2019, 4:23 PM
Harbormaster completed remote builds in B9615: Diff 8531.Dec 9 2019, 4:23 PM
ardumont accepted this revision.Dec 9 2019, 4:24 PM
ardumont added a subscriber: ardumont.

Indeed.

This revision is now accepted and ready to land.Dec 9 2019, 4:24 PM
douardda added a child revision: D2414: docker/nginx: use standard port 80 in nginx's container.Dec 9 2019, 4:25 PM
anlambert requested changes to this revision.EditedDec 9 2019, 4:27 PM
anlambert added a subscriber: anlambert.

I totally agree on this. You miss some replacements in the tests and the README though.

This revision now requires changes to proceed.Dec 9 2019, 4:27 PM
douardda added a comment.Dec 9 2019, 4:29 PM
In D2413#57044, @anlambert wrote:

I totally agree on this. You miss some replacements in the tests and the README though.

oopsie, thanks

douardda updated this revision to Diff 8538.Dec 9 2019, 4:34 PM

forgot a few matches, as noticed by anlambert

Harbormaster completed remote builds in B9622: Diff 8538.Dec 9 2019, 4:34 PM
anlambert accepted this revision.Dec 9 2019, 4:38 PM

All good !

This revision is now accepted and ready to land.Dec 9 2019, 4:38 PM
Closed by commit rDENV57ab82a18cd2: Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault (authored by douardda). · Explain WhyDec 9 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENV57ab82a18cd2: Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault.

Revision Contents
Changeset List

PathSize
docker/
16 lines
conf/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
vault.yml
vault-api.yml
2 lines
4 lines
4 lines
26 lines
services/
swh-scheduler-api/
swh-scheduler/
swh-scheduler-api/
tests/
4 lines
2 lines

Diff 8541

View Options

docker/README.md

Loading...
View Options

docker/conf/deposit.yml

Loading...
View Options

docker/conf/indexer.yml

Loading...
View Options

docker/conf/indexer_journal_client.yml

Loading...
View Options

docker/conf/lister.yml

Loading...
View Options

docker/conf/loader.yml

Loading...
View Options

docker/conf/nginx.conf

Loading...
View Options

docker/conf/vault-api.yml

Loading...
View Options

docker/conf/vault-worker.yml

Loading...
View Options

docker/conf/vault.yml

Loading...
View Options

docker/conf/web-replica.yml

Loading...
View Options

docker/conf/web.yml

Loading...
View Options

docker/docker-compose.yml

Loading...
View Options

docker/services/swh-scheduler-api/entrypoint.sh

Loading...
View Options

docker/services/swh-scheduler/entrypoint.sh

Loading...
View Options

docker/tests/run_tests.sh

Loading...
View Options

docker/tests/test_01_loader_git.sh

Loading...
About · Developer information · Legal