Page MenuHomeSoftware Heritage
Differential D2401

deposit.api: Add a basic api page to https://deposit.s.o/1
ClosedPublic
Actions

Authored by ardumont on Dec 6 2019, 9:32 AM.

Details

Reviewers
moranegg
anlambert
Group Reviewers
Reviewers
Commits
rDDEP05ad78150b51: deposit.api: Add a basic api page to avoid broken link
rDDEP101110f8b88a: deposit.urls: Improve module docstring
rDDEPb44057eb8456: homepage: Improve sentence phrasing
Summary

This makes the link https://d.s.o/1 referenced from the getting-started [1]
actually resolves to a page and not a 404.

Note: This also improve some sentence phrasing in the main homepage and some
module docstrings

Related to T2140

[1] https://docs.softwareheritage.org/devel/swh-deposit/getting-started.html

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 6 2019, 9:32 AM
swh-public-ci added a comment.Dec 6 2019, 9:34 AM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/200/ for more details.

Harbormaster completed remote builds in B9537: Diff 8457.Dec 6 2019, 9:34 AM
anlambert accepted this revision.Dec 6 2019, 12:04 PM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/deposit/api/urls.py
6 ↗(On Diff #8457)

I would rather write SWH's deposit api URL configuration here

swh/deposit/templates/homepage.html
29

s/respository/archive/

This revision is now accepted and ready to land.Dec 6 2019, 12:04 PM
ardumont updated this revision to Diff 8467.Dec 6 2019, 12:27 PM

Adapt according to review

ardumont marked 2 inline comments as done.Dec 6 2019, 12:27 PM

thx.

Adapted.

swh-public-ci added a comment.Dec 6 2019, 12:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/202/ for more details.

Harbormaster completed remote builds in B9550: Diff 8467.Dec 6 2019, 12:30 PM
moranegg added a comment.Dec 6 2019, 12:33 PM

Looks good to me too :-)

Closed by commit rDDEPb44057eb8456: homepage: Improve sentence phrasing (authored by ardumont). · Explain WhyDec 6 2019, 12:35 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEPb44057eb8456: homepage: Improve sentence phrasing.
ardumont added a commit: rDDEP101110f8b88a: deposit.urls: Improve module docstring.
ardumont added a commit: rDDEP05ad78150b51: deposit.api: Add a basic api page to avoid broken link.

Revision Contents
Changeset List

PathSize
swh/
deposit/
templates/
9 lines

Diff 8468

View Options

swh/deposit/templates/homepage.html

Loading...
About · Developer information · Legal