Page MenuHomeSoftware Heritage
Differential D24

Change the server's imports to absolute ones
ClosedPublic
Actions

Authored by qcampos on May 10 2016, 5:16 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC2c719ee74b4a: Change the server's imports to absolute ones
R65:2c719ee74b4a: Change the server's imports to absolute ones
rDOBJS3e6c9817bd51: Change the server's imports to absolute ones
rDSTO2c719ee74b4a: Change the server's imports to absolute ones
Summary

As the servers are supposed to be launched, their imports
cannot be relatives.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos updated this revision to Diff 65.May 10 2016, 5:16 PM
qcampos retitled this revision from to Change the server's imports to absolute ones.
qcampos updated this object.
qcampos edited the test plan for this revision. (Show Details)
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 10 2016, 5:16 PM
olasd added a subscriber: olasd.May 10 2016, 5:32 PM

The calling convention for the servers is python3 -m swh.storage.api.server and python3 -m swh.storage.objstorage.api.server. Doesn't that work?

qcampos added a comment.May 10 2016, 5:41 PM

Nope, that make a SystemError: Parent module '' not loaded, cannot perform relative import as the module name is __main__ when launched this way.
http://stackoverflow.com/a/16637588

ardumont accepted this revision.May 11 2016, 10:56 AM
ardumont added a reviewer: ardumont.
This revision is now accepted and ready to land.May 11 2016, 10:56 AM
Closed by commit rDSTO2c719ee74b4a: Change the server's imports to absolute ones (authored by qcampos). · Explain WhyMay 11 2016, 11:00 AM
This revision was automatically updated to reflect the committed changes.
zack edited edge metadata.May 30 2016, 3:20 PM
zack changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
7 lines
objstorage/
api/
7 lines

Diff 66

View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/objstorage/api/server.py

Loading...
About · Developer information · Legal