Page MenuHomeSoftware Heritage

Hide (so-called) errors "Local: No offset stored".
ClosedPublic

Authored by vlorentz on Dec 3 2019, 4:10 PM.

Details

Summary

We're all tired of them.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 3 2019, 4:10 PM
vlorentz updated this revision to Diff 8422.Dec 3 2019, 4:11 PM

add missing hunk

olasd added a subscriber: olasd.Dec 3 2019, 6:37 PM

To future-proof this, I suggest switching the logic to have a map between error codes and log levels in the error_cb function; I'm sure we'll want to tune other messages, and I'd prefer mapping this to a debug level log message rather than silencing it completely.

vlorentz planned changes to this revision.Dec 9 2019, 8:59 AM
vlorentz updated this revision to Diff 8596.Dec 11 2019, 3:54 PM

apply comment

olasd accepted this revision.Dec 16 2019, 1:47 PM
This revision is now accepted and ready to land.Dec 16 2019, 1:47 PM
This revision was automatically updated to reflect the committed changes.