Page MenuHomeSoftware Heritage
Differential D2365

npm: metadata -> revision: Deal with previous metadata format
ClosedPublic
Actions

Authored by ardumont on Nov 27 2019, 3:55 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDLDBASE4d789d4dd650: npm: metadata -> revision: Deal with previous metadata format
Summary

Current revision stored from the previous npm loader runs have their metadata
stored with an old format.

This patches the current npm loader to deal with it.

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 27 2019, 3:55 PM
swh-public-ci added a comment.Nov 27 2019, 3:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/246/ for more details.

Harbormaster completed remote builds in B9400: Diff 8329.Nov 27 2019, 3:57 PM
ardumont updated this revision to Diff 8331.Nov 27 2019, 4:03 PM

Update comments

swh-public-ci added a comment.Nov 27 2019, 4:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/247/ for more details.

Harbormaster completed remote builds in B9402: Diff 8331.Nov 27 2019, 4:05 PM
ardumont updated this revision to Diff 8336.Nov 27 2019, 4:16 PM

Simplify docstrings and give sample examples

swh-public-ci added a comment.Nov 27 2019, 4:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/248/ for more details.

ardumont mentioned this in D2367: pypi: metadata -> revision: Deal with previous metadata format.Nov 27 2019, 4:18 PM
Harbormaster completed remote builds in B9407: Diff 8336.Nov 27 2019, 4:18 PM
douardda accepted this revision.Nov 28 2019, 11:55 AM
This revision is now accepted and ready to land.Nov 28 2019, 11:55 AM
ardumont updated this revision to Diff 8349.Nov 28 2019, 12:00 PM

Fix docstring typo

ardumont updated this revision to Diff 8350.Nov 28 2019, 12:02 PM

Plug to master branch

This revision was landed with ongoing or failed builds.Nov 28 2019, 12:02 PM
Closed by commit rDLDBASE4d789d4dd650: npm: metadata -> revision: Deal with previous metadata format (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASE4d789d4dd650: npm: metadata -> revision: Deal with previous metadata format.
swh-public-ci added a comment.Nov 28 2019, 12:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/251/ for more details.

Harbormaster completed remote builds in B9421: Diff 8349.Nov 28 2019, 12:02 PM
Harbormaster failed remote builds in B9422: Diff 8350!
swh-public-ci added a comment.Nov 28 2019, 12:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/252/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/252/console

Revision Contents
Changeset List

PathSize
swh/
loader/
package/
51 lines
tests/
79 lines

Diff 8351

View Options

swh/loader/package/npm.py

Loading...
View Options

swh/loader/package/tests/test_npm.py

Loading...
About · Developer information · Legal