Page MenuHomeSoftware Heritage

Improve error message when save code now request fails
ClosedPublic

Authored by anlambert on Nov 25 2019, 3:30 PM.

Details

Summary

This will prevent to report an origin url to save as blacklisted while the real error was
django failing to validate CSRF (for instance when no Referer header is sent in the request).

Related to T2093

Test Plan

Cypress tests have been updated to simulate error responses and their reporting.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 25 2019, 3:30 PM
vlorentz accepted this revision.Nov 25 2019, 3:39 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
cypress/integration/origin-save.spec.js
17

Nitpick: rename unknownErr to unknownError for consistency

This revision is now accepted and ready to land.Nov 25 2019, 3:39 PM
anlambert updated this revision to Diff 8092.Nov 25 2019, 3:44 PM

Update: s/unknownErr/unknownError/