Use 'pre-commit install' as fixups hook
ClosedPublic
Actions

Authored by douardda on Nov 21 2019, 6:29 PM.

Details

Reviewers

Group Reviewers

Commits

rDENVe4bae4f26236: Remove git-(add|rm)-pro-commit-hook scripts
rDENVa2e3199ab496: Use 'pre-commit install' as fixups hook

Summary

also remove git-(add|rm)-pro-commit-hook scripts,
these should now be useless.

Diff Detail

Repository

rDENV Development environment

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 9316
Build 13634: arc lint + arc unit

Event Timeline

douardda created this revision.Nov 21 2019, 6:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 21 2019, 6:29 PM

Harbormaster completed remote builds in B9316: Diff 8049.Nov 21 2019, 6:29 PM

ardumont accepted this revision.Nov 21 2019, 6:47 PM

This revision is now accepted and ready to land.Nov 21 2019, 6:47 PM

great !

I guess this should have a Closes T1881 in its commit message before landing

bonus point: when this is landed, can we have a message to swh-devel informing people they should migrate to pre-commit, with instructions on how to do so?

In D2337#54934, @zack wrote:

great !

I guess this should have a Closes T1881 in its commit message before landing

Sure

bonus point: when this is landed, can we have a message to swh-devel informing people they should migrate to pre-commit, with instructions on how to do so?

Yes, as well as some diffs in documentations (wiki and swh-docs).

Closed by commit rDENVa2e3199ab496: Use 'pre-commit install' as fixups hook (authored by douardda). · Explain WhyNov 22 2019, 10:13 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDENVa2e3199ab496: Use 'pre-commit install' as fixups hook.

douardda added a commit: rDENVe4bae4f26236: Remove git-(add|rm)-pro-commit-hook scripts.