Page MenuHomeSoftware Heritage

Use 'pre-commit install' as fixups hook
ClosedPublic

Authored by douardda on Nov 21 2019, 6:29 PM.

Details

Summary

also remove git-(add|rm)-pro-commit-hook scripts,
these should now be useless.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Nov 21 2019, 6:29 PM
ardumont accepted this revision.Nov 21 2019, 6:47 PM
This revision is now accepted and ready to land.Nov 21 2019, 6:47 PM
zack added a subscriber: zack.Nov 21 2019, 9:53 PM

great !

I guess this should have a Closes T1881 in its commit message before landing

bonus point: when this is landed, can we have a message to swh-devel informing people they should migrate to pre-commit, with instructions on how to do so?

In D2337#54934, @zack wrote:

great !

I guess this should have a Closes T1881 in its commit message before landing

Sure

bonus point: when this is landed, can we have a message to swh-devel informing people they should migrate to pre-commit, with instructions on how to do so?

Yes, as well as some diffs in documentations (wiki and swh-docs).