Make sure TypeErrors can pass through the RPC layer
ClosedPublic
Actions

Authored by olasd on Nov 19 2019, 3:02 PM.

Details

Reviewers

zack
douardda

Commits

rDCORE155c0b226bb1: Make sure TypeErrors can pass through the RPC layer

Summary

swh.storage raises TypeErrors when type checking of incoming objects fails. We
need to make sure that these go through the RPC layer unchanged.

Test Plan

new test added to tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 19 2019, 3:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/346/ for more details.

Harbormaster completed remote builds in B9134: Diff 7942.Nov 19 2019, 3:05 PM

douardda accepted this revision.Nov 19 2019, 3:15 PM

This revision is now accepted and ready to land.Nov 19 2019, 3:15 PM

Closed by commit rDCORE155c0b226bb1: Make sure TypeErrors can pass through the RPC layer (authored by olasd). · Explain WhyNov 19 2019, 4:35 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDCORE155c0b226bb1: Make sure TypeErrors can pass through the RPC layer.

Revision Contents
Changeset List

Path

Size

swh/

core/

api/

__init__.py

15 lines

tests/

test_rpc_client_server.py

13 lines

Diff 7947

View Options

swh/core/api/init.py

View Options

swh/core/api/tests/test_rpc_client_server.py

Make sure TypeErrors can pass through the RPC layerClosedPublicActions