Differential D2271

logger: only flatten dicts if all keys are strings
ClosedPublic
Actions

Authored by olasd on Nov 13 2019, 5:28 PM.

Details

Reviewers

ardumont

Commits

rDCOREcbabde9b3673: logger: only flatten dicts if all keys are strings

Summary

This avoids blowing up when passing complex arguments (e.g. full
snapshots) to logging.debug

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9008
Build 13161: tox-on-jenkins	Jenkins
Build 13160: arc lint + arc unit

Event Timeline

olasd created this revision.Nov 13 2019, 5:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/339/ for more details.

Harbormaster completed remote builds in B9008: Diff 7822.Nov 13 2019, 5:30 PM

ardumont accepted this revision.Nov 13 2019, 5:34 PM

This revision is now accepted and ready to land.Nov 13 2019, 5:34 PM

Closed by commit rDCOREcbabde9b3673: logger: only flatten dicts if all keys are strings (authored by olasd). · Explain WhyNov 13 2019, 6:08 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDCOREcbabde9b3673: logger: only flatten dicts if all keys are strings.

Revision Contents
Changeset List

Path

Size

swh/

core/

logger.py

18 lines

tests/

test_logger.py

10 lines

Diff 7822

View Options

swh/core/logger.py