Page MenuHomeSoftware Heritage

lister.cli: Clarify cli's configuration loading step
ClosedPublic

Authored by ardumont on Thu, Nov 7, 4:08 PM.

Details

Summary

lister.debian: Actually use the db_engine passed to the hook function

The end goal being to actually be able to use it successfully (it did not work).

Test Plan
  • tox
  • Initialize a new db from scratch:
swh lister --db-url "postgresql:///?service=admin-staging-swh-lister" db-init

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Nov 7, 4:08 PM
ardumont updated this revision to Diff 7700.Thu, Nov 7, 4:13 PM

Rework commit order

ardumont updated this revision to Diff 7718.EditedThu, Nov 7, 6:08 PM

Reuse same configuration in tests without duplicating it

ardumont updated this revision to Diff 7720.Fri, Nov 8, 10:51 AM
  • lister.cli: Clarify configuration loading step
ardumont retitled this revision from lister.cli: Make the cli override through db-url or config-file work to lister.cli: Clarify cli's configuration loading step.Fri, Nov 8, 10:53 AM
ardumont edited the summary of this revision. (Show Details)
douardda accepted this revision.Fri, Nov 8, 10:57 AM
This revision is now accepted and ready to land.Fri, Nov 8, 10:57 AM