replace the 'start' argument by a 'page_token' which is now expected to be an (not
so) opaque token used for pagination.
The 'end' argument is dropped.
Adapt tests and the list_origins_by_producer() helper function (in cli.py)
accordingly.
Differential D2222
proper pagination for IndexerStorage.origin_intrinsic_metadata_search_by_producer douardda on Nov 5 2019, 4:08 PM. Authored by
Details
replace the 'start' argument by a 'page_token' which is now expected to be an (not The 'end' argument is dropped. Adapt tests and the list_origins_by_producer() helper function (in cli.py)
Diff Detail
Event TimelineComment Actions Build is green Comment Actions I would rather we move to opaque tokens for all pagination stuff. Using last this way will not work if we move the idx-storage to a non-postgresql storage, and I don't want to go through this again.
Comment Actions That's why I put a 'Note' in the Diff's description ;-)
I know. Let's have this "specify pagination" meeting ASAP. Comment Actions Build is green Comment Actions this version should address the points raised by vlorentz hopefully, since I messed heavily my git rebase... Comment Actions Build is green Comment Actions Build is green |