Page MenuHomeSoftware Heritage
Differential D2206

Fix tests for latest swh.storage and swh.model
ClosedPublic
Actions

Authored by douardda on Oct 31 2019, 9:43 AM.

Details

Reviewers
vlorentz
anlambert
Group Reviewers
Reviewers
Commits
rDCIDX03a0a3f789a4: tests: fix test_metadata.py for frozen entities in swh.model.model
rDCIDX234a7d479819: tests: update tests for storage>=0.0.155
Summary
  • update tests for storage>=0.0.155 where 'type' has moved from origin to origin_visit.
  • fix test_metadata.py for frozen entities in swh.model.model introduced in swh.model 0.0.50.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
fix-tests
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 8735
Build 12728: tox-on-jenkinsJenkins
Build 12727: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 31 2019, 9:43 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 31 2019, 9:43 AM
swh-public-ci added a comment.Oct 31 2019, 9:46 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/635/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/635/console

Harbormaster failed remote builds in B8735: Diff 7591!Oct 31 2019, 9:46 AM
douardda added a comment.Oct 31 2019, 11:43 AM

This diff needs more work for storage 0.0.156
On it

vlorentz requested changes to this revision.Oct 31 2019, 11:57 AM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/indexer/tests/utils.py
547

'type' should not be in origin

This revision now requires changes to proceed.Oct 31 2019, 11:57 AM
douardda updated this revision to Diff 7592.Oct 31 2019, 2:08 PM

modify utils.py + fix dependencies on storage so tests can pass as is

douardda added a child revision: D2207: update indexer for storage 0.0.156.Oct 31 2019, 2:08 PM
swh-public-ci added a comment.Oct 31 2019, 2:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/636/ for more details.

Harbormaster completed remote builds in B8736: Diff 7592.Oct 31 2019, 2:10 PM
anlambert accepted this revision.Oct 31 2019, 4:47 PM
anlambert added a subscriber: anlambert.

Looks good !

vlorentz accepted this revision.Nov 4 2019, 3:59 PM

Just rename origin to visit in the for loop

This revision is now accepted and ready to land.Nov 4 2019, 3:59 PM
douardda updated this revision to Diff 7636.Nov 4 2019, 4:03 PM

rename origin->visit in utils.py:fill_storage()

swh-public-ci added a comment.Nov 4 2019, 4:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/639/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/639/console

Harbormaster failed remote builds in B8803: Diff 7636!Nov 4 2019, 4:06 PM
douardda updated this revision to Diff 7637.Nov 4 2019, 4:08 PM

messed with arc...

swh-public-ci added a comment.Nov 4 2019, 4:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/640/ for more details.

Harbormaster completed remote builds in B8804: Diff 7637.Nov 4 2019, 4:10 PM
Closed by commit rDCIDX234a7d479819: tests: update tests for storage>=0.0.155 (authored by douardda). · Explain WhyNov 4 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDCIDX234a7d479819: tests: update tests for storage>=0.0.155.
douardda added a commit: rDCIDX03a0a3f789a4: tests: fix test_metadata.py for frozen entities in swh.model.model.

Revision Contents
Changeset List

PathSize
2 lines
swh/
indexer/
tests/
4 lines
7 lines
7 lines

Diff 7591

View Options

requirements-swh.txt

Loading...
View Options

swh/indexer/tests/test_metadata.py

Loading...
View Options

swh/indexer/tests/test_origin_head.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal