Page MenuHomeSoftware Heritage

Fix tests for latest swh.storage and swh.model
ClosedPublic

Authored by douardda on Thu, Oct 31, 9:43 AM.

Details

Summary
  • update tests for storage>=0.0.155 where 'type' has moved from origin to origin_visit.
  • fix test_metadata.py for frozen entities in swh.model.model introduced in swh.model 0.0.50.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Thu, Oct 31, 9:43 AM

This diff needs more work for storage 0.0.156
On it

vlorentz requested changes to this revision.Thu, Oct 31, 11:57 AM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/indexer/tests/utils.py
545

'type' should not be in origin

This revision now requires changes to proceed.Thu, Oct 31, 11:57 AM
douardda updated this revision to Diff 7592.Thu, Oct 31, 2:08 PM

modify utils.py + fix dependencies on storage so tests can pass as is

anlambert accepted this revision.Thu, Oct 31, 4:47 PM
anlambert added a subscriber: anlambert.

Looks good !

vlorentz accepted this revision.Mon, Nov 4, 3:59 PM

Just rename origin to visit in the for loop

This revision is now accepted and ready to land.Mon, Nov 4, 3:59 PM
douardda updated this revision to Diff 7636.Mon, Nov 4, 4:03 PM

rename origin->visit in utils.py:fill_storage()

douardda updated this revision to Diff 7637.Mon, Nov 4, 4:08 PM

messed with arc...