Page MenuHomeSoftware Heritage
Differential D2201

Make visit['origin'] a string everywhere (instead of a dict).
ClosedPublic
Actions

Authored by vlorentz on Oct 30 2019, 2:37 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSTOCd4540ed9f3c4: Make visit['origin'] a string everywhere (instead of a dict).
rDSTOd4540ed9f3c4: Make visit['origin'] a string everywhere (instead of a dict).
Summary

Depends on D2157, D2200

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 30 2019, 2:37 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 30 2019, 2:37 PM
Harbormaster failed remote builds in B8710: Diff 7504!Oct 30 2019, 2:37 PM
swh-public-ci added a comment.Oct 30 2019, 2:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/769/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/769/console

olasd accepted this revision.Oct 30 2019, 2:56 PM
olasd added a subscriber: olasd.

Thanks!

swh/storage/storage.py
1229–1230

I guess these two lines aren't really needed anymore. You can also add an isinstance like you did other methods.

This revision is now accepted and ready to land.Oct 30 2019, 2:56 PM
vlorentz updated this revision to Diff 7508.Oct 30 2019, 3:08 PM

remove useless query

swh-public-ci added a comment.Oct 30 2019, 3:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/770/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/770/console

swh-public-ci added a comment.Oct 30 2019, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/771/ for more details.

Harbormaster completed remote builds in B8713: Diff 7508.Oct 30 2019, 3:11 PM
Closed by commit rDSTOd4540ed9f3c4: Make visit['origin'] a string everywhere (instead of a dict). (authored by vlorentz). · Explain WhyOct 30 2019, 3:11 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOd4540ed9f3c4: Make visit['origin'] a string everywhere (instead of a dict)..
vlorentz added a commit: rDSTOCd4540ed9f3c4: Make visit['origin'] a string everywhere (instead of a dict)..Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

PathSize
2 lines
swh/
storage/
22 lines
18 lines
tests/
74 lines

Diff 7510

View Options

requirements-swh.txt

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal